microsoft / microsoft/SPTAG

Improve exception safety with smart pointers

Open
#32 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code improvement
Dominant language
C++
Stars
5k
Forks
622
Avg merge
8h 37m
Merged PRs (30d)
5

Description

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AnnService/inc/Core/Common/BKTree.h at the linked KmeansArgs class and inspect its pointer data members. Determine which members are appropriate for std::unique_ptr and audit the surrounding ownership and exception-safety implications. Done means the intended pointer members are safely managed without changing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.