reserved identifier violation
Open
Nobody has claimed this yet.
code improvement
- Dominant language
- C++
- Stars
- 5k
- Forks
- 622
- Avg merge
- 8h 37m
- Merged PRs (30d)
- 5
Description
I would like to point out that an identifier like “_SPTAG_CORE_COMMONDEFS_H_” does eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with AnnService/inc/Core/Common.h at line 4 and review the header guard identifier against the linked C++ reserved-identifier guidance. Rename it to a unique non-reserved form and confirm the header still uses a consistent guard.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100