microsoft / microsoft/SPTAG

switch CMake files from C++ 14 to C++ 17

Open
#280 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
5k
Forks
622
Avg merge
8h 37m
Merged PRs (30d)
5

Description

In commit 23c4e8449641c8534ea3fafb0abe7079dece0a36 the MSVC build files were switched from C++ 14 to C++ 17, but the CMake files were not switched to C++ 17. These files need fixing to update the C++ version to 17:

AnnService/inc/Core/Common/cuda/Makefile
CMakeLists.txt
GPUSupport/CMakeLists.txt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing AnnService/inc/Core/Common/cuda/Makefile, CMakeLists.txt, and GPUSupport/CMakeLists.txt, then compare their C++ standard settings with the MSVC change from commit 23c4e8449641c8534ea3fafb0abe7079dece0a36. Done means all three listed build files require C++17 rather than C++14.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.