microsoft / microsoft/SPTAG

set the C++ standard version via the CMAKE_*_STANDARD variables

Open
#223 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
5k
Forks
622
Avg merge
8h 37m
Merged PRs (30d)
5

Description

For the cmake builds, instead of manually passing the C++ standard via hard-coded GCC/MSVC flags, the right way to do it is to set the CMAKE_CXX_STANDARD and CMAKE_CUDA_STANDARD variables.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CMake build configuration and the hard-coded GCC/MSVC standard flags. Replace those settings with the named CMAKE_CXX_STANDARD and CMAKE_CUDA_STANDARD variables, then verify that the CMake builds use the intended C++ standard.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, compilers
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.