cmake: drop unused `COMPONENTS` from `find_package(Boost 1.67)`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 5k
- Forks
- 622
- Avg merge
- 8h 37m
- Merged PRs (30d)
- 5
Description
The COMPONENTS in calls to find_package(Boost 1.67) appear to be unused (except for unit_test_framework in Test/CMakeLists.txt) since rebuilding without them still succeeds.
$ git grep -i find_package.*boost
CMakeLists.txt:find_package(Boost 1.67 COMPONENTS system thread serialization wserialization regex filesystem)
Test/CMakeLists.txt:find_package(Boost 1.67 COMPONENTS system thread serialization wserialization regex filesystem unit_test_framework)
I suggest dropping the unused components system thread serialization wserialization regex filesystem from both of the calls.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with CMakeLists.txt and Test/CMakeLists.txt, using the git grep command in the issue to inspect both Boost calls. Remove the unused system, thread, serialization, wserialization, regex, and filesystem components while retaining unit_test_framework for tests. Reconfigure and rebuild to confirm the project still succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100