microsoft / microsoft/SPTAG

Python install fails when installing SPTAG.py as file is in inc dir not src dir

Open
#201 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
5k
Forks
622
Avg merge
8h 37m
Merged PRs (30d)
5

Description

When trying to install the Python bindings, the cmake command fails because it tries to install the SPTAG.py file from the src directory instead of the inc directory, but the command that generates SPTAG.py writes it to the inc directory. Switching line 74 of Wrappers/CMakeLists.txt from Wrappers/src/SPTAG.py to Wrappers/inc/SPTAG.py fixes this problem.

CMake Error at Wrappers/cmake_install.cmake:84 (file):
  file INSTALL cannot find
  "/path/to/build/Wrappers/src/SPTAG.py": No such file
  or directory.
Call Stack (most recent call first):
  cmake_install.cmake:50 (include)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect line 74 of Wrappers/CMakeLists.txt and the command that generates Wrappers/inc/SPTAG.py. Reproduce the Python bindings installation to confirm the missing-file error, then verify that installation completes using the generated file's actual location.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.