microsoft / microsoft/Qcodes

fix AMI430_3D driver: Parameters should not return arrays

Open
#908 1 comment 0 reactions 1 assignee View on GitHub

@sohailc is already working on this.

Since Dec 8, 2017.

bug
Dominant language
Python
Stars
459
Forks
359
Avg merge
3d 6h
Merged PRs (30d)
73

Description

The AMI430_3D driver has a number of parameters which return arrays, e.g.:

"cartesian_measured", "cartesian", "spherical_measured", etc.

As these are regular parameters instead of ArrayParameters, this is wrong.

The proper fix is to make these parameters, ArrayParameters.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.