Connect message does not work for Instrument with no get_idn command defined
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 459
- Forks
- 359
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 73
Description
When using instruments that do not have an "IDN" method the Instrument.connect_message does not work.
I propose resolving this by adding the following method to the Instrument base class.
def get_idn(self):
return {'driver': str(self.__class__), 'name': self.name}
I think it is quite useful to have this method be part of the base class as we also want to see this message for e.g., Dummy instruments or things like meta instruments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Instrument base class and the Instrument.connect_message implementation. Check how connect_message handles instruments without get_idn, then verify the fallback for Dummy instruments and meta instruments produces the proposed driver and name information.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100