microsoft / microsoft/Qcodes

get_idn should not throw for virtual instruments

Open
#4,611 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
459
Forks
359
Avg merge
3d 6h
Merged PRs (30d)
73

Description

Virtual instruments should either override get_idn to not fail and respond with something useful, or we should rework this so get_idn is not implemented like this for the generic class.

the reason for the failure is that get_idn calls `.ask` which is not implemented for virtual instruments.

An example of this issue is in #4590

Contributor guide

Open the contributing guide

Research direction

Start by tracing get_idn in the generic instrument class and checking how virtual instruments implement or omit .ask. Read the example in issue #4590 to understand the failure. Done means virtual instruments no longer throw from get_idn and provide a useful response or an explicitly supported alternative.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.