microsoft / microsoft/Qcodes

hdf5 write_copy error

Open
#343 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
459
Forks
359
Avg merge
3d 6h
Merged PRs (30d)
73

Description

@AdriaanRol
### Steps to reproduce
1. load a dataset
2. change formatter to HDF5
3. use `dataset.write_copy(path="something")`
### Expected behaviour

it should save tghe dataset in hadf5 format
### Actual behaviour

write_metadata() got an unexpected keyword argument 'read_first'
which gets called in:

```
c:\users\damaz de jong\pycharmprojects\qcodes\qcodes\data\data_set.py in write_copy(self, path, io_manager, location)
684 self.snapshot()
685 self.formatter.write_metadata(self, io_manager, location,
--> 686 read_first=False)
687 finally:
688 for array_id, array in self.arrays.items():
```

My pycharm also tells me that your signature on hdf5_format.py line 234 does not match the signature of the base class `Formatter`
### System

**operating system**
Windows 10

**qcodes branch**
master

**qcodes commit**
35515fa

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in qcodes/data/data_set.py at write_copy and compare its write_metadata call with the HDF5 formatter signature in hdf5_format.py around line 234 and the base Formatter declaration. Reproduce the Windows HDF5 write_copy steps, then verify that the dataset saves successfully without the unexpected read_first argument error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.