Allow adding parameters to Monitor using station.add_component
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 459
- Forks
- 359
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 73
Description
Hi,
I have a small feature pull request. To my knowledge, it is not currently possible to add parameters to the Monitor through the station object without using load_instrument. This change allows adding e.g. standalone parameters to the monitor, or instrument parameters after using load_instrument.
Changes proposed:
- Add a parameter to Monitor when using
station.add_component, ifadd_to_monitorargument isTrue(defaultFalse). - Using
remove_componentalso deletes the parameter from Monitor (current implementation seems to assume that the component is an instrument)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing station.add_component and remove_component, then inspect how Monitor and load_instrument currently handle parameters. Confirm the existing behavior for instrument and standalone parameters. Done means add_component can optionally add a parameter when add_to_monitor is true, while remove_component also removes that parameter from Monitor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100