microsoft / microsoft/Qcodes

Minor issues with SG584 driver

Open
#1,377 0 comments 0 reactions 0 assignees View on GitHub
bug driver
Dominant language
Python
Stars
459
Forks
359
Avg merge
3d 6h
Merged PRs (30d)
73

Description

The driver does not check if the HF option is avialable before adding parameters related to that

See https://www.thinksrs.com/downloads/pdfs/manuals/SG380m.pdf page 64. The rf doubler is needed for this to work correctly.

The lower frequency limit does not take the LF module into account

Contributor guide

Open the contributing guide

Research direction

Start by locating the SG584 driver and reviewing how it adds HF-related parameters and calculates the lower frequency limit. Use the SG380m manual, page 64, to confirm the RF doubler and HF/LF module requirements; done means HF parameters are guarded by availability and the lower limit accounts for the LF module.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.