microsoft / microsoft/ProcMon-for-Linux
Consider checking the real user id as opposed to the effective user id.
Open
Nobody has claimed this yet.
bug
- Dominant language
- C
- Stars
- 4.7k
- Forks
- 295
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 9
Description
line 17 checks the effective uid, signalling it's ok to come from a set user id root environment. However, right under it there's a call to system(), which clearly signals this code has no business being used in such an environment.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/procmon.cpp line 17 and inspect the nearby system() call and UID check. Confirm how the current effective-UID check behaves in a set-user-ID root environment, then update the check so the issue's requested real-user-ID behavior is satisfied and verify that such an environment is rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100