microsoft / microsoft/PowerToys

CmdPal: PerfMon units Bytes and Binary bytes have same calculation, differs just in unit text

Open Beginner friendly
#49,071 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug Needs-Triage Product-Command Palette
Dominant language
C
Stars
139k
Forks
8.6k
PR merge metrics
PR metrics pending

Description

### Microsoft PowerToys version

100.2

### Installation method

Dev build in Visual Studio

### Area(s) with issue?

Command Palette

### Steps to reproduce

[FormatAsBinaryBytesPerSecString](https://github.com/microsoft/PowerToys/blob/1d11b732b7ba7dbb265d1151531655fd8d83c76d/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PerformanceMonitor/PerformanceWidgetsPage.cs#L855) and [FormatAsBytesPerSecString](https://github.com/microsoft/PowerToys/blob/1d11b732b7ba7dbb265d1151531655fd8d83c76d/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PerformanceMonitor/PerformanceWidgetsPage.cs#L819) differ only in the unit prefix text (K/M/G vs Ki/Mi/Gi), but both use 1024 as the multiplier.

### ✔️ Expected Behavior

When both methods are present, I'd expect one to use the binary multiplier (1024) and the other to use the decimal multiplier (1000).

### ❌ Actual Behavior

_No response_

### Upload Bug Report ZIP-file

_No response_

### Additional Information

_No response_

### Other Software

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PerformanceMonitor/PerformanceWidgetsPage.cs at FormatAsBinaryBytesPerSecString and FormatAsBytesPerSecString. Compare their current multipliers and unit prefixes, then verify that binary units use 1024 while decimal units use 1000 and that the displayed values remain correctly labeled.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop, performance
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
75/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.