microsoft / microsoft/PowerToys

Keyboard shortcut rendering in settings doesn't take keyboard layout into account

Open
#47,503 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug Needs-Triage Product-General
Dominant language
C
Stars
139k
Forks
8.6k
PR merge metrics
PR metrics pending

Description

### Microsoft PowerToys version

0.99.1

### Installation method

WinGet

### Area(s) with issue?

General

### Steps to reproduce

(Sorry if this duplicates an existing issue, there are just too many issues with the keywords "keyboard" and "shortcut"...)

When the current keyboard layout is French AZERTY, the first ("unshifted") key on the digit row is `&`, not `1` as on a US QWERTY keyboard.

So, I would expect that when setting a keyboard shortcut with that key anywhere in PowerToys, for instance the "Zoom toggle" function in ZoomIt, which by default has a shortcut of `Ctrl` combined with the aforementioned key, PowerToys would display (render) that shortcut as `Ctrl+&`, not `Ctrl+1`

### ✔️ Expected Behavior

(Just an example) the shortcut for "Zoom toggle" when the keyboard layout is French should be displayed as `Ctrl+&`

This is what is displayed by my https://gist.github.com/sba923/7ea3d013b1f758a947eea6c2e4f89f73#file-get-zoomithelp-ps1 script (needs https://gist.github.com/sba923/7ea3d013b1f758a947eea6c2e4f89f73#file-get-zoomitoption-ps1):

Image

This is what, for instance, Visual Studio Code does:

Image

### ❌ Actual Behavior

The shortcut for "Zoom toggle" when the keyboard layout is French is displayed as `Ctrl+1`

### Upload Bug Report ZIP-file

_No response_

### Additional Information

Windows 10 Enterprise Retail build 10.0.19045.7184.amd64fre.vb_release.191206-1406

### Other Software

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points; first reproduce the shortcut display with a French AZERTY layout and trace the PowerToys shortcut-rendering path. Done means the affected shortcut is displayed using the active layout, such as Ctrl+&, rather than Ctrl+1.

Written by the indexing model from the issue text.

Assessment

Domain
desktop, internationalization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.