microsoft / microsoft/PowerToys
Accessibility: Focus order and tab stops issues in Settings UI
- Dominant language
- C
- Stars
- 139k
- Forks
- 8.6k
- PR merge metrics
- PR metrics pending
Description
# Accessibility: Inconsistent focus order/tab stops due to Focusable/IsTabStop overrides (ZoomIt-focused)
Problem (ZoomIt scope):
The ZoomIt settings page contains a top-level `SettingsPageControl` with `IsTabStop="False"` and other potentially focus-suppressing templates. These settings and custom control templates can prevent keyboard users and screen readers from reaching important controls in ZoomIt.
Impacted ZoomIt areas:
- `ZoomItPage.xaml` top-level `SettingsPageControl` uses `IsTabStop="False"`.
- `ShortcutControl` rows and action buttons inside ZoomIt cards (Break, Record, Demo) where `Focusable` or `IsTabStop` may be explicitly set by templates.
How verified:
- Reviewed `ZoomItPage.xaml` which declares `IsTabStop="False"` on the `SettingsPageControl` root; repository grep shows `ShortcutControl` and other controls manage `Focusable`/`IsTabStop` programmatically in related modules.
Steps to reproduce (ZoomIt-focused):
1. Open `Settings -> ZoomIt`.
2. Press Tab repeatedly from the module list into the ZoomIt content area and observe whether tab focus reaches expected controls (shortcuts, toggles, browse buttons).
Acceptance criteria (ZoomIt):
- Keyboard users can tab into the ZoomIt settings area and navigate controls in a logical, predictable order.
Progress (concise):
- Work started on branch `fix/zoomit-accessibility` (local). A formal PR will be opened; commit/PR links will be added to this issue when the branch is pushed.
- Test plan: `TEST_PLAN_ZOOMIT_ACCESSIBILITY.md` contains manual tab-order verification steps and references to UI test stubs.
- New findings (documented, not fixed in this issue):
- Decorative `FontIcon` glyphs in shortcut dialog may be announced redundantly by screen readers (needs investigation across other dialogs).
Notes:
- This issue now tracks the remaining verification and acceptance criteria; implementation details and commits will be referenced from a PR to avoid embedding fixes in the issue body.
Contributor guide
Research direction
Start with ZoomItPage.xaml and inspect the SettingsPageControl, ShortcutControl rows, and related templates for the focus settings named in the issue. Use TEST_PLAN_ZOOMIT_ACCESSIBILITY.md to run the manual tab-order checks. Done means keyboard users can enter the ZoomIt settings area and reach its controls in a logical, predictable order.
Written by the indexing model from the issue text.
Assessment
- Domain
- accessibility, desktop, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100