microsoft / microsoft/PowerToys
[File Locksmith] ExplorerCommand::LaunchUI ignores CreateProcessW failure
Open
Beginner friendly
Nobody has claimed this yet.
Issue-Bug
Product-File Locksmith
- Dominant language
- C
- Stars
- 139k
- Forks
- 8.6k
- PR merge metrics
- PR metrics pending
Description
Bug
CreateProcessW() return unchecked. On failure, CloseHandle on uninitialized handles + returns S_OK.
Fix: Check return, HRESULT_FROM_WIN32(GetLastError()) on failure.
Found by AI test review fleet
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ExplorerCommand::LaunchUI and inspect its CreateProcessW call and failure path. Verify the process-creation result is handled before using the process and thread handles, and that failure returns the Windows error as an HRESULT; done when the unchecked-failure behavior is covered by the relevant existing tests or validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100