microsoft / microsoft/PowerApps-Samples
ConfigureCrmServerSideSync - Date comparison for checking for expired certs is not correct
Open
Beginner friendly
Nobody has claimed this yet.
PowerShell
- Dominant language
- C#
- Stars
- 2k
- Forks
- 1.8k
- PR merge metrics
- No merged PRs in 30d
Description
The check on line 175 is not evaluated correctly as $servicePrincipalCredentials[$i].endDateTime is a string and $currentDateTime is a DateTime.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in powershell/ServerSideSync/ConfigureCrmServerSideSync.ps1 at the linked check around lines 175-188. Inspect how $servicePrincipalCredentials[$i].endDateTime and $currentDateTime are compared, then verify that expired certificates are detected correctly when the check runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100