microsoft / microsoft/Power-Fx
IR should Call TryGetConstantValue
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
Have IR leverage Binder.TryGetConstantValue.
This function exists and is used by PAClient to do constant folding for strings.
Ie, at compile time, it will translate "A" & "B" into a single string "AB".
This is only used by PAClient today, so it's a test hole.
Call it from IR some that:
- we get test coverage of this function
- More convergence between C# and JS backends.
- potential perf benefits :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IR code and Binder.TryGetConstantValue, then inspect how PAClient currently uses the function for string constant folding. Compare the C# and JavaScript backend paths and existing tests. Done means IR invokes the binder functionality and coverage verifies that expressions such as "A" & "B" fold to "AB".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, javascript
- Domain
- compilers, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100