microsoft / microsoft/Power-Fx
Void issues
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
-
IsError( If( false, GUID(), Now() ) )returns false -
If(false, {}, [])-> returns empty table, should be error -
If(False, {}, 1)-> returns1should be an error.
2&3 seems to be due to special casing here. https://github.com/microsoft/Power-Fx/blob/81e7c0bee1e1b3dc45f03ed302d2592cf316bd54/src/libraries/Microsoft.PowerFx.Core/Types/DType.cs#L3991
(Related PR: https://github.com/microsoft/Power-Fx/pull/1309)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/libraries/Microsoft.PowerFx.Core/Types/DType.cs around line 3991 and reproduce the three If/IsError expressions from the issue. Review the related pull request for context, then verify that the inconsistent results are corrected so the invalid branches are reported as errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100