microsoft / microsoft/Power-Fx
Apply return result type check to all function implementations.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
Functions implemented via AsyncFunctionPtr have an additional type check on the return result.
This chekc ought to be apply to all implementations.
It fails on some, including these:
- AsTypeIsTypeParseJSONTests.cs ,
- BlobTests.cs line
- ValidateNoRecordToRecordAggregateCoercionCurrencyth
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs around line 398 and trace the return-result check used by AsyncFunctionPtr. Review the failing cases named in AsTypeIsTypeParseJSONTests.cs, BlobTests.cs, and ValidateNoRecordToRecordAggregateCoercionCurrencyth. Done means the same return type validation applies to all function implementations and these failures are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100