microsoft / microsoft/Power-Fx

Remove IAsyncTexlFunction4 and IAsyncTexlFunction5

Open
#2,818 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3.4k
Forks
358
Avg merge
10h 34m
Merged PRs (30d)
3

Description

These are used by implementatons from Fx.Json.

The challenge is that Fx.Json can't depend on Fx.Interpreter (because PAClient depends on Fx.Json).
That's a unique requirement - most everything else that wants to provide an interpreter implementation can safely depend on Fx.Interpreter. So we may need to special case something here. Perhaps a unique PowerFxJson contract that lives in core, is implemented by Fx.Json, and handled by Fx.Interpreter

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the uses of IAsyncTexlFunction4 and IAsyncTexlFunction5 across Fx.Json and Fx.Interpreter, including the PAClient dependency constraint. Determine whether a core PowerFxJson contract can replace them without introducing the forbidden dependency; done means the obsolete interfaces are removed and the affected implementations and interpreter handling remain compatible.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.