microsoft / microsoft/Power-Fx

Join - warn if predicate doesn't use both LeftRecord and RightRecord

Open
#2,795 0 comments 0 reactions 1 assignee View on GitHub

@anderson-joyle is already working on this.

Since Dec 30, 2024.

Dominant language
C#
Stars
3.4k
Forks
358
Avg merge
10h 34m
Merged PRs (30d)
3

Description

Join() should warn if predicate doesn't use both LeftRecord and RightRecord.

This would flag cases like this, which could produce surprising results:
Join(Sequence(3), Sequence(3), LeftRecord.Value in [1,2], JoinType.Left, RightRecord.Value As R2)

Filter() has same issue

We have a basic warning for literals:
Filter([10,20,30], true)

But no warning for:
Filter([10,20,30], true && true)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.