microsoft / microsoft/Power-Fx

Connectors shouldn't need both HttpClient and uriPrefix

Open
#2,780 1 comment 0 reactions 1 assignee View on GitHub

@LucGenetier is already working on this.

Since Dec 17, 2024.

  • #2785 by @LucGenetier — open
Breaking API Connectors
Dominant language
C#
Stars
3.4k
Forks
358
Avg merge
10h 34m
Merged PRs (30d)
3

Description

HttpClient already provides the base address. So we shouldn't also need uriPrefix (which is conceptually just part of the base address).

An additional benefit is that this lets the host fully control the endpoint.

  • They can pick v1 vs. v2, (will this also lets us revert #2718 and instead defer that responsibility to the host?)
  • They can call CDP hosted outside of APIM. (this includes localhost)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.