microsoft / microsoft/Power-Fx
UO to DateTime should work without explicit coercion
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
The expression DateTimeValue(ParseJSON("""8/13/2024 9:10 AM""")) should work without the need to call Text first.
When passing an UO value, there is an extra regex check IsValidDateTimeUO.
https://github.com/microsoft/Power-Fx/blob/aa26cfadd8b1158fc23a81bd70972e16cb434530/src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryUntypedObject.cs#L523C21-L523C38
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryUntypedObject.cs around IsValidDateTimeUO, then trace how DateTimeValue handles the untyped object returned by ParseJSON. Verify that DateTimeValue(ParseJSON("8/13/2024 9:10 AM")) works without an explicit Text conversion and add or update regression coverage if the surrounding tests identify the appropriate location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100