microsoft / microsoft/Power-Fx
IntelliSense should not suggest option sets for non-open set function arguments
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
Ideally, we would have blocked these scenarios as part of strongly typed enums. But, that is a breaking change, so the next best thing we can do is not suggest using an enum in these places where they are very unlikely to be used:
Enums should be suggested in places where a strongly typed enum is the type of the parameter:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IntelliSense logic that proposes option sets for function arguments and any tests covering enum suggestions. Compare arguments with strongly typed enum parameters and verify that non-open-set arguments no longer receive option-set suggestions while valid enum parameters still do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100