microsoft / microsoft/Power-Fx

Possible UDF breaking change when new functions are added

Open
#2,214 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3.4k
Forks
358
Avg merge
10h 34m
Merged PRs (30d)
3

Description

As we progressively add more functions to BuiltinFunctionsCore, greater is the risk of UDF breaks.
https://github.com/microsoft/Power-Fx/blob/3e4e9fb5c12805185144cf9fa59f608418ed4ba4/src/libraries/Microsoft.PowerFx.Core/Syntax/UserDefinitions.cs#L101


Refers to: src/libraries/Microsoft.PowerFx.Core/Syntax/UserDefinitions.cs:103 in aa1dd48. [](commit_id = aa1dd4848e9454aafbe2fa99c8481edc687011f8, deletion_comment = False)

Originally posted by @MikeStall in https://github.com/microsoft/Power-Fx/issues/2211#issuecomment-1948741166

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/libraries/Microsoft.PowerFx.Core/Syntax/UserDefinitions.cs around line 103 and inspect how BuiltinFunctionsCore is used when user-defined functions are processed. Determine whether adding built-in functions can break existing UDFs, then define regression coverage that demonstrates the compatibility expectation and passes after the issue is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.