microsoft / microsoft/Power-Fx
ShowColumns() doesn't work properly with Display Name Identifier.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
First(ShowColumns(Accounts, 'Account Name')).'Account Name' should work.
but it only allows logical names, Ie forces to use First(ShowColumns(Accounts, 'Account Name')).name
Add back the below test, re-weritten with ShowColumns() to DisplayNameTests.cs>ValidateDisplayNames
[InlineData("First(Nested.Inner).Inner", "First(NestedDisplay.InnerDisplay).InnerDisplay", true)]
[InlineData("First(NestedDisplay.InnerDisplay).InnerDisplay", "First(Nested.Inner).Inner", false)]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DisplayNameTests.cs and the ValidateDisplayNames test, using the provided ShowColumns() expressions as the reproduction cases. Run the test to confirm the current behavior, then update the relevant test coverage and implementation so display-name and logical-name forms behave as specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100