microsoft / microsoft/Power-Fx
Symbols: Composed symbol tables don't do FunctionNames
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
ComposedReadOnlySymbolTable properly handles function lookup, but does not handle function names.
This should probably be overridden.
public IEnumerable<string> FunctionNames => _functions.FunctionNames;
It's also suspect that ReadOnlySymbolTable has mutable state like:
internal readonly Dictionary<string, NameLookupInfo> _variables = new Dictionary<string, NameLookupInfo>();
private protected readonly TexlFunctionSet _functions = new TexlFunctionSet();
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/libraries/Microsoft.PowerFx.Core/Public/Config/ReadOnlySymbolTable.cs at the FunctionNames property, then inspect ComposedReadOnlySymbolTable and how it handles function lookup. Confirm that FunctionNames reflects the composed tables, and add or update coverage for the expected names if the relevant tests can be located.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100