microsoft / microsoft/Power-Fx
Check for Runtime mismatch for all type of Function Invocation.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
Today we check for runtime mismatch while Invoking only TexlFunction.
https://github.com/microsoft/Power-Fx/blob/main/src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs#L288
This causes us to miss issues in other invocations and we tend to find those issues later when those functions are wrapped inside TexlFunction. (e.g. https://github.com/microsoft/Power-Fx/issues/1598)
We should check the return type on all of the invocations (e.g. IAsyncTexlFunction)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs around the runtime-mismatch check at line 288, then trace the other invocation paths, including IAsyncTexlFunction. Confirm how return types are checked for each path and identify the existing coverage related to issue 1598. Done means runtime mismatches are detected consistently for every function invocation type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100