microsoft / microsoft/Power-Fx
Set() should propagate ErrorValue.
Open
@anderson-joyle is already working on this.
Since May 9, 2023.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
Set(field, value) can fail. For example, if field is a dataverse table and we fail to make the update.
However, we drop the return value here:
https://github.com/microsoft/Power-Fx/blob/00685893e02d2847e269213a62a2bf2c4b6fb1cf/src/libraries/Microsoft.PowerFx.Interpreter/Environment/RowScopeSymbolValues.cs#L42
> Microsoft.PowerFx.Dataverse.Eval.dll!Microsoft.PowerFx.Dataverse.DataverseRecordValue.UpdateFieldsAsync(Microsoft.PowerFx.Types.RecordValue record, System.Threading.CancellationToken cancellationToken) Line 171 C#
Microsoft.PowerFx.Core.dll!Microsoft.PowerFx.Types.RecordValue.UpdateFields(Microsoft.PowerFx.Types.RecordValue changeRecord) Line 164 C#
Microsoft.PowerFx.Interpreter.dll!Microsoft.PowerFx.RowScopeSymbolValues.Set(Microsoft.PowerFx.ISymbolSlot slot, Microsoft.PowerFx.Types.FormulaValue value) Line 27 C#
Microsoft.PowerFx.Interpreter.dll!Microsoft.PowerFx.EvalVisitor.TryHandleSet(Microsoft.PowerFx.Core.IR.Nodes.CallNode node, Microsoft.PowerFx.EvalVisitorContext context) Line 166 C#
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.