microsoft / microsoft/Power-Fx
ErrNumberExpected should give actual type too
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
We replaced a bunch of cases of ErrBadType_ExpectedType_ProvidedType with ErrNumberExpected.
So before, we had this, which included actual type.
[1]: {Error 8-15: Invalid argument type (Table). Expecting a Number value instead.}
Now we get this, which doesn't include actual type.
{Error 8-15: Expected number. We expect a number at this point in the formula.}
Very likely related to #1333 which appears to have added more cases returning ErrNumberExpected, such as in StatisticalFunctions.CheckTypes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing ErrNumberExpected and the StatisticalFunctions.CheckTypes cases mentioned in the issue, then compare them with the replaced ErrBadType_ExpectedType_ProvidedType paths. Confirm that number errors preserve the actual argument type and add or update coverage for the reported Table-versus-Number message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100