microsoft / microsoft/PixEvents

PIXGetCaptureState() needs to identify whether internal/external capture is enabled

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
104
Forks
14
PR merge metrics
No merged PRs in 30d

Description

This call just returns 0. That is not a valid implemantion, and doesn't correspond with the documentation. 0 means no capture is active. At least, it should mark a flag when Begin/EndCapture is called by the app (internal), but also when the Pix app starts a capture (external).

That way apps can skip calling PIX calls until a capture starts.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at PIXGetCaptureState() and trace the BeginCapture/EndCapture paths mentioned in the issue. Determine how an external Pix capture is signaled, then verify that the function reports active or inactive capture state for both internal and external captures.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.