[Feature] pnpm/corepack support
@cormacpayne is already working on this.
Since Jan 14, 2024.
- Dominant language
- C#
- Stars
- 881
- Forks
- 195
- Avg merge
- 20h 13m
- Merged PRs (30d)
- 13
Description
Feature Request
From https://github.com/microsoft/Oryx/issues/1150#issuecomment-1886067023
We're not currently looking to support pnpm. Closing this issue for now, please create a new issue and link to this one if you feel strongly.
I feel strongly about this and decided to open a new issue.
My suggestions is at follows:
- Detect presence of
packageManagerkey inpackage.json. - If found,
- Run
corepack enable - Run
npm install/yarn install/pnpm installdepending on the package manager name
- Run
- If not found,
- Just run
npm installas before
- Just run
How this will improve things:
-
Azure Static Site and Azure Web Service users can build their app without having to set up
PRE_BUILD_COMMANDandCUSTOM_BUILD_COMMAND. I use Netlify and Vercel, and they are supported out-of-the-box, so I expect the same in other hosting services. Azure services not recognizing pnpm in my project is a turn off for me. -
GitHub Codespaces currently run
npm installeven in pnpm projects. This means not only it takes a longer time for Codespace to initialize pnpm projects (due to waiting for npm install), afterwards I have to go ahead andrm -rf node_modules package-lock.jsonand runpnpm installagain.
In short, supporting pnpm via corepack will improve both developer experience in Codespaces and deployment experiences in Azure services.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.