microsoft / microsoft/OpenAPI.NET.OData
The default for UseStringArrayForQueryOptionsSchema should be false
Open
Nobody has claimed this yet.
priority:p1
type:bug
type:regression
- Dominant language
- C#
- Stars
- 240
- Forks
- 70
- Avg merge
- 7h 59m
- Merged PRs (30d)
- 13
Description
Added in #499
Setting the default to true effectively changed every conversion from emitting array of enum values to arrays of strings silently.
This is a strong behaviour change, and the default should have been false.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs at line 334 and review the setting introduced by #499. Change its default as requested, then verify that conversion behavior no longer silently changes from enum arrays to string arrays.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100