microsoft / microsoft/Omex

Disable extended logging in DiagnosticsObserversInitializer by default

Open
#368 0 comments 0 reactions 1 assignee View on GitHub

@AndreyTretyak is already working on this.

Since Jun 9, 2021.

bug
Dominant language
C#
Stars
77
Forks
40
Avg merge
1d 1h
Merged PRs (30d)
10

Description

By default the DiagnosticsObserversInitializer logs extended details when the HttpClient receives an error response. In particular cases the log entry can contain the payload of the HTTP request message including Authorization and custom header values. This is a concern from privacy and security perspective as the header values might contain personally identifiable information and non encrypted access tokens.

Extended logging information should be off by default and should be explicitly enabled so that developers are in control of what is being logged.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.