microsoft / microsoft/ObjectStoreProvider

remove range does not support non-primary index

Open
#43 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15
Forks
19
PR merge metrics
No merged PRs in 30d

Description

can easily reproduce this from UT, both impacting inmemory and db provider

the root cause here is because removeInternal() is actually only accepting primary keys

image

because the mergedData is keyed by primary key
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing UT reproduction for remove range and trace removeInternal through the mergedData structure. Compare the in-memory and database providers, then verify that removing a range through a non-primary index works in both providers and that the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.