microsoft / microsoft/OSSGadget

ExtractGitHubUris does not do what the comment claims

Open
#287 1 comment 0 reactions 1 assignee View on GitHub

@scovetta is already working on this.

Since Nov 19, 2021.

bug
Dominant language
C#
Stars
371
Forks
58
No merged PRs in 30d

Description

ExtractGitHubUris claims to check the URIs it generates against the PackageURL but actually just adds all of the GitHub uris from the searchText parameter while ignoring the provided PackageURL. I'm not sure if the behavior or the comment is correct, but if the PackageURL is not used it should be removed from the method signature.

https://github.com/microsoft/OSSGadget/blob/270a7a22fce5dd46f993d1e0ade6efafe098aef7/src/Shared/PackageManagers/GitHubProjectManager.cs#L22-L49

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.