Potential typo in `sample_perspective`: `tgt_fov_max` instead of `tgt_fov_x_max`
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3k
- Forks
- 234
- PR merge metrics
- No merged PRs in 30d
Description
Hi, thanks for your great work!
I was reading through the code and noticed a potential typo in the sample_perspective function. In this line:
tgt_fov_x_min, tgt_fov_max = max(np.deg2rad(fov_range_absolute_min), tgt_fov_x_min), min(np.deg2rad(fov_range_absolute_max), tgt_fov_x_max)
Should tgt_fov_max be tgt_fov_x_max, or did I misunderstand?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open moge/utils/data_augmentation.py and inspect sample_perspective around line 37, comparing the assigned variable with the surrounding field names. Confirm whether the maximum value should use tgt_fov_x_max; done means the variable name is consistent and the function remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100