microsoft / microsoft/MSBuildSdks
RobocopyFiles target from Microsoft.Build.Artifacts not compatible with UseArtifactsOutput
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 508
- Forks
- 94
- Avg merge
- 6h 40m
- Merged PRs (30d)
- 2
Description
I'm trying to migrate a 2k csproj solution to <UseArtifactsOutput>true</UseArtifactsOutput> with a <ArtifactsPath>$(MSBuildThisFileDirectory)target/artifacts</ArtifactsPath>.
One of the first things I ran into is that it seems the RobocopyFiles target doesn't run. It's using Condition="'$(EnableArtifacts)' != 'false'". Is there a way to keep RobocopyFiles enabled? We have about 600 instances of it being used. It's doing things like:
<Robocopy Include="$(PkgMyNuget)\lib\$(MyNetVersion)\">
<DestinationFolder>$(TestServicesPath)\Taef\blah</DestinationFolder>
<FileMatch>Some.Thing*.dll</FileMatch>
</Robocopy>
We also use some of the other MSBuildSdks like CopyOnWrite.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the RobocopyFiles target, its EnableArtifacts condition, and the UseArtifactsOutput and ArtifactsPath properties, but no source file or test. Start by locating the target and tracing how those properties affect it; done means existing Robocopy items remain enabled and work with the new artifacts layout, including the shown XML pattern.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100