microsoft / microsoft/MSBuildSdks

[NoTargets] Why not `<EnableDefaultItems>false</EnableDefaultItems>`?

Open
#371 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
508
Forks
94
Avg merge
6h 40m
Merged PRs (30d)
2

Description

Why does NoTargets keep any of the implicit includes of the Sdk?

I can see that in #114 resource compilation was disabled.
Yet, the other defaults are left enabled.

My assumption was that all implicit includes of Compile, None, EmbeddedResource etc. would be disabled in a NoTargets project.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the NoTargets SDK behavior for implicit Compile, None, and EmbeddedResource items, and compare it with the change described in #114. Determine whether EnableDefaultItems is intended to be false for NoTargets; done means the expected behavior is established and covered by an appropriate regression test or documented rationale.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.