microsoft / microsoft/MInference

[Question]: Confusion about Optimal Search Pattern Configuration

Open
#64 2 comments 1 reaction 1 assignee View on GitHub

@iofu728 is already working on this.

Since Aug 6, 2024.

question
Dominant language
Python
Stars
1.2k
Forks
82
Avg merge
1d 18h
Merged PRs (30d)
1

Description

Confusion about Optimal Search Pattern Configuration

First of all, thank you for your outstanding research.
I noticed that in Appendix E of the paper, it is mentioned that "according to the ablation study, using only the Vertical-Slash pattern significantly impacts performance in highly dynamic tasks like KV retrieval."
However, the model configuration provided in the repository still uses the Vertical-Slash pattern exclusively.
You mentioned in other comments that "the search_pattern function reroutes to vertical_and_slash because our tests have shown that this setting offers better generalization and efficiency across different context windows and tasks."
This seems to contradict the conclusion given in the paper, which leaves me somewhat confused.
Could you please clarify how we should set the optimal search pattern in practice?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.