microsoft / microsoft/MIEngine
Address race by f91dec6
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 859
- Forks
- 233
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 3
Description
From https://github.com/microsoft/MIEngine/pull/1362
https://github.com/microsoft/MIEngine/commit/f91dec6efdf5bd70b06ded5d82301a0968e02b05 also introduces a race here where if we get a stopping event extremely quickly, we could wind up blowing away the stopped state. We really need some sort of lock around the call to step.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #1362 and commit f91dec6, then locate the step call involved in the stopping event handling. Verify the race where a rapid stopping event can overwrite stopped state, and confirm that the completed change prevents that state loss.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100