microsoft / microsoft/LatentSpatialMemory

Question about two differences between paper and released code

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
325
Forks
11
Avg merge
1h 16m
Merged PRs (30d)
3

Description

Hi, thanks for releasing the code!
While reading it, I found two places where it seems to differ from the paper, and I'd like to confirm which version was used for the reported results.

  1. No re-encoding in the memory update

The paper (Sec. 4.4, Algorithm 1) re-encodes decoded frames into clean latents (z̃ₜ = E(Iₜ)) before back-projection. In the code, update_latent_memory() passes the generated latents directly to lpc.update() with no vae.encode call. Which one matches the released recipe?

  1. Side branch frozen in Stage 2

The paper (Sec. 4.5) says LoRA is jointly optimized with the side branch in Stage 2. In scripts/train.py, set_stage_trainable("lora") freezes the side branch (model.vace.eval()) and the optimizer only receives LoRA parameters. Was the side branch actually frozen in Stage 2?

Apologies if I've misread anything — thanks in advance!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Secs. 4.4 and 4.5 of the paper, then inspect update_latent_memory(), lpc.update(), and scripts/train.py, especially set_stage_trainable("lora"). Compare the released implementation with the two described training steps; done means confirming which behavior produced the reported results and documenting the clarification.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.