microsoft / microsoft/KBLaM

In experiments/train.py,training labels problem

Open
#79 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
1.5k
Forks
125
Avg merge
22d 8m
Merged PRs (30d)
1

Description

Image

As shown over here, the 2 labels creating method only masked the starting special tokens until the start of user content, not the whole query inputs until the start assistant content like what regular SFT does.

Does this make sense? train not just the answer but the query content as well? Or what it wants is not only, just train for instruction following, answer generation ability, but also a bit like pretrain for latent sentiment space alignment for the adapters?

And what does these comment notes means? "Not sure... Possibly what they want is...", "...Not 100% this is correct"
Aren't the authors of 《KBLaM》 provided this code for paper reproduction? What labels they used for training exactly? Does anyone have any ideas?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in experiments/train.py and locate the method that creates the two training labels. Compare its masking boundaries with the issue's description of regular SFT, then review the KBLaM paper or reproduction notes for the intended labels. Done means the intended masking behavior and the meaning of the comments are established, with any discrepancy clearly identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.