Readme train.py command doesn't create saved output once training is complete
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 1.5k
- Forks
- 125
- Avg merge
- 22d 8m
- Merged PRs (30d)
- 1
Description
The readme instructs to use 601 steps: --total_steps 601
https://github.com/microsoft/KBLaM/blob/main/README.md?plain=1#L58
However the train.py file has a static value of 3000 steps for the save period: save_period=3000
https://github.com/microsoft/KBLaM/blob/main/experiments/train.py#L955
After reaching 100% training, the output folder was empty:
Training ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% Loss: 9.2729 0:00:002 0:00:2704:29
Took about 4 hours to train, but then it didn't save the result 😅
So should the suggested steps in the readme be increased, or should the static save_period value be lowered?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the documented command in README.md around line 58 and compare its 601 total steps with save_period=3000 in experiments/train.py around line 955. Reproduce the documented training run or inspect the save logic, then ensure the completed run writes output to the expected folder and that the README and training settings agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100