microsoft / microsoft/FluidFramework

[code-simplifier] chore: clarify review fleet JSON format

Open
#27,123 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

agentic-workflows automation code-quality refactoring
Dominant language
TypeScript
Stars
4.9k
Forks
586
Avg merge
1d 15h
Merged PRs (30d)
146

Description

Overview

This PR makes small clarity-focused tweaks to files touched in the last 24 hours, without changing behavior.

Changes
  • .github/scripts/consolidate_reviews.py
    • Update the module docstring and CLI help text to reflect the current review-*.json input format (instead of the old review-*.md/regex format).
  • scripts/codespace-setup/install-build-cli.sh
    • Use command -v (captured once) when reporting the installed flub path.
Testing
  • Ran python .github/scripts/consolidate_reviews.py --help.
  • Ran a local smoke test generating a report from a sample review-correctness.json.
Changes based on
  • #27113 (review fleet JSON output)
  • #27119 (install build-cli in AI-enabled codespace)

Generated by Code Simplifier ·

To install this agentic workflow, run

gh aw add github/gh-aw/.github/workflows/code-simplifier.md@94662b1dee8ce96c876ba9f33b3ab8be32de82a4
  • expires on Apr 23, 2026, 7:59 AM UTC

[!NOTE]
This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch code-simplifier/2026-04-22-review-fleet-docs-7dce808c11489fab.

Click here to create the pull request

To fix the permissions issue, go to SettingsActionsGeneral and enable Allow GitHub Actions to create and approve pull requests.

Show patch preview (54 of 54 lines)
From 4d5ff2a3de1000f6aff1fc0f0080f5c4bd9caf77 Mon Sep 17 00:00:00 2001
From: Copilot CLI <copilot-cli@users.noreply.github.com>
Date: Wed, 22 Apr 2026 07:56:48 +0000
Subject: [PATCH] chore: clarify review fleet JSON format

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/scripts/consolidate_reviews.py       | 9 +++++----
 scripts/codespace-setup/install-build-cli.sh | 3 ++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/scripts/consolidate_reviews.py b/.github/scripts/consolidate_reviews.py
index 032e9e1..fc3069f 100644
--- a/.github/scripts/consolidate_reviews.py
+++ b/.github/scripts/consolidate_reviews.py
@@ -1,9 +1,10 @@
 #!/usr/bin/env python3
 """Consolidate review fleet findings into a single PR report.
 
-Reads review-*.md files from a directory, extracts findings in the format
-[SEVERITY] file:line — description — fix, de-duplicates by file:line,
-and outputs a consolidated markdown report.
+Reads review-*.json files from a directory and extracts findings from the
+`{"findings": [{"severity", "location", "description", "fix"}]}` structure.
+Findings are de-duplicated by location (file:line) and emitted as a consolidated
+markdown report.
 
 Usage:
     python consolidate_reviews.py <reviews-dir> <run-url> [-o report.md]
@@ -234,7 +235,7 @@ def build_report(findings: list[Finding], run_url: str, pr_number: int | None =
 
 def main(argv: list[str] | None = None) -> int:
     parser = argparse.ArgumentParser(description=__doc__)
-    parser.add_argument("reviews_dir", type=Path, help="Directory containing review-*.md files")
+    parser.add_argument("reviews_dir", type=Path, help="Directory containing review-*.json files")
     parser.add_argument("run_url", help="URL to the workflow run")
     parser.add_argument("-o", "--output", type=Path, default=Path("report.md"), help="Output file path")
     parser.add_argument("--pr-number", type=int, help="Pull request number for deterministic emoji set select
... (truncated)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/scripts/consolidate_reviews.py and scripts/codespace-setup/install-build-cli.sh, then run the listed --help command and local sample smoke test. Done means the help and module documentation describe review-*.json input and the install script reports the captured flub path without behavior changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, shell
Domain
devops, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.