microsoft / microsoft/FeatureManagement-JavaScript
getVariant/TargetingFilter might accept any context type
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 6
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
We're actively debating this now- but I think context here should be unknown. https://github.com/microsoft/FeatureManagement-Dotnet/pull/484/files#r1717629098
Originally posted by @rossgrambo in https://github.com/microsoft/FeatureManagement-JavaScript/pull/13#discussion_r1717630553
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the getVariant and TargetingFilter type definitions and review the linked pull request discussion about the context type. Resolve whether context should accept unknown values, then update the relevant tests so the intended type behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100