microsoft / microsoft/FeatureManagement-Dotnet

FeatureGate filter question

Open
#341 3 comments 0 reactions 1 assignee View on GitHub

@zhiyuanliang-ms is already working on this.

Since Feb 1, 2024.

Dominant language
C#
Stars
1.2k
Forks
129
Avg merge
1d 1h
Merged PRs (30d)
5

Description

Currently, the FeatureGate is a kind of ActionFilter, should we consider using ResourceFilter or AuthorizationFilter instead, that would be more efficient to avoid some unnecessary flow when feature disabled

https://github.com/microsoft/FeatureManagement-Dotnet/blob/e4adec40c8397e0d537bb053aef0e9fc8ed622bf/src/Microsoft.FeatureManagement.AspNetCore/FeatureGateAttribute.cs#L18

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.