microsoft / microsoft/FeatureManagement-Dotnet
Adding Instrumentation code
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.2k
- Forks
- 129
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 5
Description
I'm wondering whether there is appetite from the maintainers to accept a PR that would add ActivitySource instrumentation to both the base library and also the ASP.NET core one.
Specifically, I'm looking at the code that gets features flags in the FeatureManager and also adding the enabled/disabled state to ASP.NET core, and potentially some other Activity based code in the ASP.NET Core library.
The usecase here is that this is important information for debugging production as it forms part of the request/response lifecycle, and also influences things like code paths of the request.
We can discuss specifics, I just want to know that there's a chance of this getting merged if I do the work.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the FeatureManager code that gets feature flags and the corresponding ASP.NET Core library code. Clarify the instrumentation scope with maintainers first; done would mean an agreed ActivitySource approach covering feature evaluation and the enabled or disabled state in ASP.NET Core.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend, observability-sre
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 18/100